Please fix DESTDIR in makemkv-bin's Makefile

The place to discuss linux version of MakeMKV
Post Reply
rjmorris
Posts: 2
Joined: Wed Jul 22, 2015 12:20 am

Please fix DESTDIR in makemkv-bin's Makefile

Post by rjmorris » Wed Jul 22, 2015 1:00 am

This has been mentioned at least twice before with no response and apparently no action taken, so I'm not optimistic that my message will have any impact either. I'll try anyway in case the right person happens to notice this time. Do the developers read the Linux forums?

Previous posts:
Dec. 19, 2014: http://www.makemkv.com/forum2/viewtopic ... dir#p36912
Nov. 18, 2011: http://www.makemkv.com/forum2/viewtopic ... dir#p16878

To summarize, the way DESTDIR is specified in the Makefile for makemkv-bin is broken for anyone who wants to install somewhere other than /usr. I want to install to /usr/local, but I can't because the install commands are defined like:

Code: Select all

install -t $(DESTDIR)/usr/bin bin/$(ARCH)/makemkvcon
No matter how I set DESTDIR, it will never go into /usr/local because of that extraneous /usr after DESTDIR. The 2014 post suggested adding a PREFIX variable and replacing /usr with $(PREFIX). That would work and would be fine with me, but a simpler solution would be to just remove all occurences of /usr and set DESTDIR to /usr by default.

Because of this brokenness, every time I get a new version, I have to remember to remove all the /usr from the Makefile before I install. Sure, it's only a minor hassle, but it's knowingly broken and could be fixed so easily. Please make this change.

mike admin
Posts: 3584
Joined: Wed Nov 26, 2008 2:26 am
Contact:

Re: Please fix DESTDIR in makemkv-bin's Makefile

Post by mike admin » Thu Jul 23, 2015 2:11 pm

Will be fixed in the next version.

rjmorris
Posts: 2
Joined: Wed Jul 22, 2015 12:20 am

Re: Please fix DESTDIR in makemkv-bin's Makefile

Post by rjmorris » Fri Jul 24, 2015 2:54 am

mike admin wrote:Will be fixed in the next version.
Thank you very much!

ndjamena
Posts: 830
Joined: Mon Jan 07, 2013 12:23 am

Re: Please fix DESTDIR in makemkv-bin's Makefile

Post by ndjamena » Fri Jul 24, 2015 8:09 am

OK, I don't use Linux but I have to say this...

After almost 4 years... COOL!

Post Reply